forked from miguelcobain/ember-paper
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade paper rebased #14
Open
bhabanip07
wants to merge
73
commits into
xomaczar:ptn-1.0-ember-paper-1.0.0-beta.9
Choose a base branch
from
bhabanip07:upgrade-paper-rebased
base: ptn-1.0-ember-paper-1.0.0-beta.9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade paper rebased #14
bhabanip07
wants to merge
73
commits into
xomaczar:ptn-1.0-ember-paper-1.0.0-beta.9
from
bhabanip07:upgrade-paper-rebased
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add failing tests for tile order and length changes * Expose didUpdate callback on grid-list update * remove layout-padding remnant * Sort tiles by dom order on grid-list didUpdate * Add tests for basic grid-list attributes
1. For paper-input, validate only when its value changes. 2. For paper-autocomplete, validate only when selection is changed.
Hi, I saw that this issue miguelcobain#791 hasn't been fixed yet. Here's a PR to fix it. I've added a test and an example of a disabled tab in the dummy app.
Deprecations Added in 3.4 Use closure actions instead of `sendAction` https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action
…lcobain#794) In the angular implementation, they allow you to customize the button by using a ["highlightClass"](https://github.com/angular/material/blob/v1.1.4/src/components/toast/toast.js#L174): > If set, the given class will be applied to the highlighted action button.<br/> > This allows you to specify the highlight color easily. Highlight classes are `md-primary`, `md-warn` and `md-accent
1. For paper-input, validate only when value changes 2. For paper-autocomplete, validate when selection is made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.